Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text body to all emails #4262

Closed
wants to merge 2 commits into from
Closed

Conversation

ruslandoga
Copy link
Contributor

Changes

Closes #4249

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga force-pushed the add-text-body-to-all-emails branch 4 times, most recently from 8df1c56 to 72291ca Compare June 23, 2024 10:40
@@ -102,7 +102,7 @@ defmodule Plausible.Imported.Importer do

@callback name() :: atom()
@callback label() :: String.t()
@callback email_template() :: String.t()
@callback email_template() :: atom | String.t()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just atom now?

Copy link
Contributor Author

@ruslandoga ruslandoga Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, yes. But I thought we could still allow strings as well since they are accepted by Bamboo's render function.

@ukutaht
Copy link
Contributor

ukutaht commented Jul 16, 2024

Hmm I'm not a fan of having to maintain two sets of email templates.

  • Can this issue be solved some other way?
  • Is it possible to generate the text version of an email based on the html version?

@ukutaht ukutaht closed this Jul 17, 2024
@ruslandoga ruslandoga deleted the add-text-body-to-all-emails branch July 17, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bamboo.Mua configuration fix for some mailing servers
3 participants